Skip to content

Commit

Permalink
chelsio: sparse warning fixes (old cxgb2)
Browse files Browse the repository at this point in the history
Fix problems detected by sparse:
1. whole chunk of MAC code was for defined and never used
2. hook for running ext intr in workqueue wasn't being used

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Oct 10, 2007
1 parent 3bf76b8 commit 33a85aa
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 370 deletions.
2 changes: 1 addition & 1 deletion drivers/net/chelsio/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

obj-$(CONFIG_CHELSIO_T1) += cxgb.o

cxgb-$(CONFIG_CHELSIO_T1_1G) += mac.o mv88e1xxx.o vsc7326.o
cxgb-$(CONFIG_CHELSIO_T1_1G) += mv88e1xxx.o vsc7326.o
cxgb-objs := cxgb2.o espi.o tp.o pm3393.o sge.o subr.o \
mv88x201x.o my3126.o $(cxgb-y)
1 change: 1 addition & 0 deletions drivers/net/chelsio/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ extern void t1_interrupts_enable(adapter_t *adapter);
extern void t1_interrupts_disable(adapter_t *adapter);
extern void t1_interrupts_clear(adapter_t *adapter);
extern int t1_elmer0_ext_intr_handler(adapter_t *adapter);
extern void t1_elmer0_ext_intr(adapter_t *adapter);
extern int t1_slow_intr_handler(adapter_t *adapter);

extern int t1_link_start(struct cphy *phy, struct cmac *mac, struct link_config *lc);
Expand Down
368 changes: 0 additions & 368 deletions drivers/net/chelsio/mac.c

This file was deleted.

2 changes: 1 addition & 1 deletion drivers/net/chelsio/subr.c
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@ static int asic_slow_intr(adapter_t *adapter)
if (cause & F_PL_INTR_PCIX)
t1_pci_intr_handler(adapter);
if (cause & F_PL_INTR_EXT)
t1_elmer0_ext_intr_handler(adapter);
t1_elmer0_ext_intr(adapter);

/* Clear the interrupts just processed. */
writel(cause, adapter->regs + A_PL_CAUSE);
Expand Down

0 comments on commit 33a85aa

Please sign in to comment.