Skip to content

Commit

Permalink
ath5k: fix Security issue in DebugFS part of ath5k
Browse files Browse the repository at this point in the history
http://bugzilla.kernel.org/show_bug.cgi?id=12076

Remove any write access to groups and others, only keep write permission
to its owner, usually only root user.

Reported-by: Jérôme Poulin <jeromepoulin@gmail.com>
Signed-off-by: Cheng Renquan <crquan@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Cheng Renquan authored and John W. Linville committed Nov 25, 2008
1 parent b4b6cda commit 33ab625
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/net/wireless/ath5k/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -417,19 +417,19 @@ ath5k_debug_init_device(struct ath5k_softc *sc)
sc->debug.debugfs_phydir = debugfs_create_dir(wiphy_name(sc->hw->wiphy),
ath5k_global_debugfs);

sc->debug.debugfs_debug = debugfs_create_file("debug", 0666,
sc->debug.debugfs_debug = debugfs_create_file("debug", S_IWUSR | S_IRUGO,
sc->debug.debugfs_phydir, sc, &fops_debug);

sc->debug.debugfs_registers = debugfs_create_file("registers", 0444,
sc->debug.debugfs_registers = debugfs_create_file("registers", S_IRUGO,
sc->debug.debugfs_phydir, sc, &fops_registers);

sc->debug.debugfs_tsf = debugfs_create_file("tsf", 0666,
sc->debug.debugfs_tsf = debugfs_create_file("tsf", S_IWUSR | S_IRUGO,
sc->debug.debugfs_phydir, sc, &fops_tsf);

sc->debug.debugfs_beacon = debugfs_create_file("beacon", 0666,
sc->debug.debugfs_beacon = debugfs_create_file("beacon", S_IWUSR | S_IRUGO,
sc->debug.debugfs_phydir, sc, &fops_beacon);

sc->debug.debugfs_reset = debugfs_create_file("reset", 0222,
sc->debug.debugfs_reset = debugfs_create_file("reset", S_IWUSR,
sc->debug.debugfs_phydir, sc, &fops_reset);
}

Expand Down

0 comments on commit 33ab625

Please sign in to comment.