Skip to content

Commit

Permalink
PM: Remove unnecessary goto from device_resume_noirq()
Browse files Browse the repository at this point in the history
In device_resume_noirq() there is the 'End' label and the associated
goto statement that aren't strictly necessary, so rework the code to
get rid of them.  Also modify device_suspend_noirq() so that it looks
completely analogous to device_resume_noirq().

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
  • Loading branch information
Rafael J. Wysocki committed Dec 15, 2009
1 parent f251177 commit 33c3374
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions drivers/base/power/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -372,14 +372,11 @@ static int device_resume_noirq(struct device *dev, pm_message_t state)
TRACE_DEVICE(dev);
TRACE_RESUME(0);

if (!dev->bus)
goto End;

if (dev->bus->pm) {
if (dev->bus && dev->bus->pm) {
pm_dev_dbg(dev, state, "EARLY ");
error = pm_noirq_op(dev, dev->bus->pm, state);
}
End:

TRACE_RESUME(error);
return error;
}
Expand Down Expand Up @@ -615,10 +612,7 @@ static int device_suspend_noirq(struct device *dev, pm_message_t state)
{
int error = 0;

if (!dev->bus)
return 0;

if (dev->bus->pm) {
if (dev->bus && dev->bus->pm) {
pm_dev_dbg(dev, state, "LATE ");
error = pm_noirq_op(dev, dev->bus->pm, state);
}
Expand Down

0 comments on commit 33c3374

Please sign in to comment.