Skip to content

Commit

Permalink
acer-wmi: Rename mail LED correctly & remove hardcoded colour
Browse files Browse the repository at this point in the history
The mail LED name for acer-wmi currently hardcodes in the colour as green.
This is wrong, since many of the newer laptops now come with an orange
LED, and we have no way of telling what colour is used on a given system.

Also, rename the mail LED to be inline with the current recommendations of
the LED class documentation.

Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Carlos Corbacho authored and Len Brown committed Mar 11, 2008
1 parent 2f44bbb commit 343c004
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Documentation/laptops/acer-wmi.txt
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ can be added to acer-wmi.

The LED is exposed through the LED subsystem, and can be found in:

/sys/devices/platform/acer-wmi/leds/acer-mail:green/
/sys/devices/platform/acer-wmi/leds/acer-wmi::mail/

The mail LED is autodetected, so if you don't have one, the LED device won't
be registered.
Expand Down
2 changes: 1 addition & 1 deletion drivers/misc/acer-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ enum led_brightness value)
}

static struct led_classdev mail_led = {
.name = "acer-mail:green",
.name = "acer-wmi::mail",
.brightness_set = mail_led_set,
};

Expand Down

0 comments on commit 343c004

Please sign in to comment.