Skip to content

Commit

Permalink
bnx2: In bnx2_set_mac_link() return void rather then int
Browse files Browse the repository at this point in the history
bnx2_set_mac_link() doesn't need to return any error codes.  And
all the callers don't check the return code. It is safe to
change the return type to a void.

Signed-off-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Acked-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Benjamin Li authored and David S. Miller committed Sep 18, 2008
1 parent d286600 commit 344478d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/net/bnx2.c
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,7 @@ bnx2_init_all_rx_contexts(struct bnx2 *bp)
}
}

static int
static void
bnx2_set_mac_link(struct bnx2 *bp)
{
u32 val;
Expand Down Expand Up @@ -1193,8 +1193,6 @@ bnx2_set_mac_link(struct bnx2 *bp)

if (CHIP_NUM(bp) == CHIP_NUM_5709)
bnx2_init_all_rx_contexts(bp);

return 0;
}

static void
Expand Down

0 comments on commit 344478d

Please sign in to comment.