Skip to content

Commit

Permalink
KVM: handle emulation failure case first
Browse files Browse the repository at this point in the history
If emulation failed return immediately.

Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
  • Loading branch information
Gleb Natapov authored and Avi Kivity committed Aug 1, 2010
1 parent 8fe681e commit 3457e41
Showing 1 changed file with 15 additions and 16 deletions.
31 changes: 15 additions & 16 deletions arch/x86/kvm/x86.c
Original file line number Diff line number Diff line change
Expand Up @@ -3924,22 +3924,6 @@ int emulate_instruction(struct kvm_vcpu *vcpu,

restart:
r = x86_emulate_insn(&vcpu->arch.emulate_ctxt, &emulate_ops);
shadow_mask = vcpu->arch.emulate_ctxt.interruptibility;

if (r == 0)
kvm_x86_ops->set_interrupt_shadow(vcpu, shadow_mask);

if (vcpu->arch.pio.count) {
if (!vcpu->arch.pio.in)
vcpu->arch.pio.count = 0;
return EMULATE_DO_MMIO;
}

if (vcpu->mmio_needed) {
if (vcpu->mmio_is_write)
vcpu->mmio_needed = 0;
return EMULATE_DO_MMIO;
}

if (r) { /* emulation failed */
/*
Expand All @@ -3955,6 +3939,21 @@ int emulate_instruction(struct kvm_vcpu *vcpu,
return EMULATE_FAIL;
}

shadow_mask = vcpu->arch.emulate_ctxt.interruptibility;
kvm_x86_ops->set_interrupt_shadow(vcpu, shadow_mask);

if (vcpu->arch.pio.count) {
if (!vcpu->arch.pio.in)
vcpu->arch.pio.count = 0;
return EMULATE_DO_MMIO;
}

if (vcpu->mmio_needed) {
if (vcpu->mmio_is_write)
vcpu->mmio_needed = 0;
return EMULATE_DO_MMIO;
}

if (vcpu->arch.exception.pending)
vcpu->arch.emulate_ctxt.restart = false;

Expand Down

0 comments on commit 3457e41

Please sign in to comment.