Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 254581
b: refs/heads/master
c: bc6f387
h: refs/heads/master
i:
  254579: 4b20deb
v: v3
  • Loading branch information
Jeff Skirvin authored and Dan Williams committed Jul 3, 2011
1 parent d99fc07 commit 345998c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: a8a0a133b03c6863d0f77229d19befca4de905fa
refs/heads/master: bc6f387d3156702a0430585b93c04934254c0de1
18 changes: 6 additions & 12 deletions trunk/drivers/scsi/isci/task.c
Original file line number Diff line number Diff line change
Expand Up @@ -1563,7 +1563,7 @@ static void isci_wait_for_smp_phy_reset(struct isci_remote_device *idev, int phy
}

static int isci_reset_device(struct isci_host *ihost,
struct isci_remote_device *idev, int hard_reset)
struct isci_remote_device *idev)
{
struct sas_phy *phy = sas_find_local_phy(idev->domain_dev);
struct isci_port *iport = idev->isci_port;
Expand Down Expand Up @@ -1593,7 +1593,7 @@ static int isci_reset_device(struct isci_host *ihost,
if (!scsi_is_sas_phy_local(phy))
set_bit(IPORT_BCN_BLOCKED, &iport->flags);

rc = sas_phy_reset(phy, hard_reset);
rc = sas_phy_reset(phy, true);

/* Terminate in-progress I/O now. */
isci_remote_device_nuke_requests(ihost, idev);
Expand Down Expand Up @@ -1633,8 +1633,8 @@ int isci_task_I_T_nexus_reset(struct domain_device *dev)
{
struct isci_host *ihost = dev_to_ihost(dev);
struct isci_remote_device *idev;
int ret, hard_reset = 1;
unsigned long flags;
int ret;

spin_lock_irqsave(&ihost->scic_lock, flags);
idev = isci_lookup_device(dev);
Expand All @@ -1645,10 +1645,7 @@ int isci_task_I_T_nexus_reset(struct domain_device *dev)
goto out;
}

if (dev->dev_type == SATA_DEV || (dev->tproto & SAS_PROTOCOL_STP))
hard_reset = 0;

ret = isci_reset_device(ihost, idev, hard_reset);
ret = isci_reset_device(ihost, idev);
out:
isci_put_device(idev);
return ret;
Expand All @@ -1659,11 +1656,8 @@ int isci_bus_reset_handler(struct scsi_cmnd *cmd)
struct domain_device *dev = sdev_to_domain_dev(cmd->device);
struct isci_host *ihost = dev_to_ihost(dev);
struct isci_remote_device *idev;
int ret, hard_reset = 1;
unsigned long flags;

if (dev->dev_type == SATA_DEV || (dev->tproto & SAS_PROTOCOL_STP))
hard_reset = 0;
int ret;

spin_lock_irqsave(&ihost->scic_lock, flags);
idev = isci_lookup_device(dev);
Expand All @@ -1674,7 +1668,7 @@ int isci_bus_reset_handler(struct scsi_cmnd *cmd)
goto out;
}

ret = isci_reset_device(ihost, idev, hard_reset);
ret = isci_reset_device(ihost, idev);
out:
isci_put_device(idev);
return ret;
Expand Down

0 comments on commit 345998c

Please sign in to comment.