Skip to content

Commit

Permalink
PNP: add debug message for adding new device
Browse files Browse the repository at this point in the history
Add PNP debug message when adding a device, remove similar PNPACPI message
with less information.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Adam Belay <ambx1@neo.rr.com>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Bjorn Helgaas authored and Linus Torvalds committed Oct 17, 2007
1 parent 36405e9 commit 348366b
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 5 deletions.
28 changes: 24 additions & 4 deletions drivers/pnp/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,11 @@ int __pnp_add_device(struct pnp_dev *dev)
spin_unlock(&pnp_lock);

ret = device_register(&dev->dev);
if (ret == 0)
pnp_interface_attach_device(dev);
return ret;
if (ret)
return ret;

pnp_interface_attach_device(dev);
return 0;
}

/*
Expand All @@ -138,12 +140,30 @@ int __pnp_add_device(struct pnp_dev *dev)
*/
int pnp_add_device(struct pnp_dev *dev)
{
int ret;

if (dev->card)
return -EINVAL;

dev->dev.parent = &dev->protocol->dev;
sprintf(dev->dev.bus_id, "%02x:%02x", dev->protocol->number,
dev->number);
return __pnp_add_device(dev);
ret = __pnp_add_device(dev);
if (ret)
return ret;

#ifdef CONFIG_PNP_DEBUG
{
struct pnp_id *id;

dev_printk(KERN_DEBUG, &dev->dev, "%s device, IDs",
dev->protocol->name);
for (id = dev->id; id; id = id->next)
printk(" %s", id->id);
printk(" (%s)\n", dev->active ? "active" : "disabled");
}
#endif
return 0;
}

void __pnp_remove_device(struct pnp_dev *dev)
Expand Down
1 change: 0 additions & 1 deletion drivers/pnp/pnpacpi/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ static int __init pnpacpi_add_device(struct acpi_device *device)
is_exclusive_device(device))
return 0;

pnp_dbg("ACPI device : hid %s", acpi_device_hid(device));
dev = kzalloc(sizeof(struct pnp_dev), GFP_KERNEL);
if (!dev) {
pnp_err("Out of memory");
Expand Down

0 comments on commit 348366b

Please sign in to comment.