Skip to content

Commit

Permalink
i40evf: make comparisons consistent
Browse files Browse the repository at this point in the history
Most of the null-checking in this driver is of the style if (!foo),
except these few. Make these checks consistent with the rest of the
code.

Change-ID: I991924f34072fa607a1b626a8b3f1fa5195d43e9
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Mitch Williams authored and Jeff Kirsher committed Nov 20, 2014
1 parent 75a6443 commit 348d499
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/net/ethernet/intel/i40evf/i40evf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -669,9 +669,9 @@ i40evf_vlan_filter *i40evf_add_vlan(struct i40evf_adapter *adapter, u16 vlan)
struct i40evf_vlan_filter *f;

f = i40evf_find_vlan(adapter, vlan);
if (NULL == f) {
if (!f) {
f = kzalloc(sizeof(*f), GFP_ATOMIC);
if (NULL == f)
if (!f)
return NULL;

f->vlan = vlan;
Expand Down Expand Up @@ -774,9 +774,9 @@ i40evf_mac_filter *i40evf_add_filter(struct i40evf_adapter *adapter,
udelay(1);

f = i40evf_find_filter(adapter, macaddr);
if (NULL == f) {
if (!f) {
f = kzalloc(sizeof(*f), GFP_ATOMIC);
if (NULL == f) {
if (!f) {
clear_bit(__I40EVF_IN_CRITICAL_TASK,
&adapter->crit_section);
return NULL;
Expand Down Expand Up @@ -2138,7 +2138,7 @@ static void i40evf_init_task(struct work_struct *work)
ether_addr_copy(netdev->perm_addr, adapter->hw.mac.addr);

f = kzalloc(sizeof(*f), GFP_ATOMIC);
if (NULL == f)
if (!f)
goto err_sw_init;

ether_addr_copy(f->macaddr, adapter->hw.mac.addr);
Expand Down

0 comments on commit 348d499

Please sign in to comment.