Skip to content

Commit

Permalink
ftrace: Remove failures file
Browse files Browse the repository at this point in the history
The failures file in the debugfs tracing directory would list the
functions that failed to convert when the old dead ftrace daemon
tried to update code but failed. Since this code is now dead along
with the daemon the failures file is useless. Remove it.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Steven Rostedt authored and Steven Rostedt committed Apr 30, 2011
1 parent 8ab2b7e commit 3499e46
Showing 1 changed file with 2 additions and 37 deletions.
39 changes: 2 additions & 37 deletions kernel/trace/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -1355,9 +1355,8 @@ static int __init ftrace_dyn_table_alloc(unsigned long num_to_init)
enum {
FTRACE_ITER_FILTER = (1 << 0),
FTRACE_ITER_NOTRACE = (1 << 1),
FTRACE_ITER_FAILURES = (1 << 2),
FTRACE_ITER_PRINTALL = (1 << 3),
FTRACE_ITER_HASH = (1 << 4),
FTRACE_ITER_PRINTALL = (1 << 2),
FTRACE_ITER_HASH = (1 << 3),
};

#define FTRACE_BUFF_MAX (KSYM_SYMBOL_LEN+4) /* room for wildcards */
Expand Down Expand Up @@ -1487,12 +1486,6 @@ t_next(struct seq_file *m, void *v, loff_t *pos)
rec = &iter->pg->records[iter->idx++];
if ((rec->flags & FTRACE_FL_FREE) ||

(!(iter->flags & FTRACE_ITER_FAILURES) &&
(rec->flags & FTRACE_FL_FAILED)) ||

((iter->flags & FTRACE_ITER_FAILURES) &&
!(rec->flags & FTRACE_FL_FAILED)) ||

((iter->flags & FTRACE_ITER_FILTER) &&
!(rec->flags & FTRACE_FL_FILTER)) ||

Expand Down Expand Up @@ -1633,24 +1626,6 @@ ftrace_avail_open(struct inode *inode, struct file *file)
return ret;
}

static int
ftrace_failures_open(struct inode *inode, struct file *file)
{
int ret;
struct seq_file *m;
struct ftrace_iterator *iter;

ret = ftrace_avail_open(inode, file);
if (!ret) {
m = file->private_data;
iter = m->private;
iter->flags = FTRACE_ITER_FAILURES;
}

return ret;
}


static void ftrace_filter_reset(int enable)
{
struct ftrace_page *pg;
Expand Down Expand Up @@ -2448,13 +2423,6 @@ static const struct file_operations ftrace_avail_fops = {
.release = seq_release_private,
};

static const struct file_operations ftrace_failures_fops = {
.open = ftrace_failures_open,
.read = seq_read,
.llseek = seq_lseek,
.release = seq_release_private,
};

static const struct file_operations ftrace_filter_fops = {
.open = ftrace_filter_open,
.read = seq_read,
Expand Down Expand Up @@ -2683,9 +2651,6 @@ static __init int ftrace_init_dyn_debugfs(struct dentry *d_tracer)
trace_create_file("available_filter_functions", 0444,
d_tracer, NULL, &ftrace_avail_fops);

trace_create_file("failures", 0444,
d_tracer, NULL, &ftrace_failures_fops);

trace_create_file("set_ftrace_filter", 0644, d_tracer,
NULL, &ftrace_filter_fops);

Expand Down

0 comments on commit 3499e46

Please sign in to comment.