Skip to content

Commit

Permalink
net/9p: fail when user specifies a transport which we can't find
Browse files Browse the repository at this point in the history
If the user specifies a transport and we can't find it, we failed back
to the default trainsport silently.  This patch will make the code
complain more loudly and return an error code.

Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
  • Loading branch information
Eric Van Hensbergen committed Feb 8, 2010
1 parent 562ada6 commit 349d3bb
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions net/9p/client.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,13 @@ static int parse_opts(char *opts, struct p9_client *clnt)
break;
case Opt_trans:
clnt->trans_mod = v9fs_get_trans_by_name(&args[0]);
if(clnt->trans_mod == NULL) {
P9_DPRINTK(P9_DEBUG_ERROR,
"Could not find request transport: %s\n",
(char *) &args[0]);
ret = -EINVAL;
goto free_and_return;
}
break;
case Opt_legacy:
clnt->dotu = 0;
Expand All @@ -117,6 +124,7 @@ static int parse_opts(char *opts, struct p9_client *clnt)
}
}

free_and_return:
kfree(options);
return ret;
}
Expand Down

0 comments on commit 349d3bb

Please sign in to comment.