Skip to content

Commit

Permalink
nfsd4: merge 3 setclientid cases to 2
Browse files Browse the repository at this point in the history
Boy, is this simpler.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
  • Loading branch information
J. Bruce Fields committed Jun 1, 2012
1 parent 8f93071 commit 34b232b
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -2195,16 +2195,11 @@ nfsd4_setclientid(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
new = create_client(clname, dname, rqstp, &clverifier);
if (new == NULL)
goto out;
if (!conf) {
/* case 4: placed first, because it's the normal case */
gen_clid(new);
} else if (same_verf(&conf->cl_verifier, &clverifier)) {
if (conf && same_verf(&conf->cl_verifier, &clverifier))
/* case 1: probable callback update */
copy_clid(new, conf);
} else { /* conf && !same_verf(): */
/* cases 2, 3: probable client reboot: */
else /* case 4 (new client) or cases 2, 3 (client reboot): */
gen_clid(new);
}
/*
* XXX: we should probably set this at creation time, and check
* for consistent minorversion use throughout:
Expand Down

0 comments on commit 34b232b

Please sign in to comment.