---

yaml --- r: 289135 b: refs/heads/master c: 6f6c4dc h: refs/heads/master i: 289133: 3195b52 289131: 6515603 289127: 5ecb807 289119: f55b159 v: v3
git-mirror · Feb 24, 2012 · 34c4f73 · 34c4f73
1 parent ad355e7
commit 34c4f73
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 1ca1a92cc6d337a149d1e37d4ab0db8ad45b0fde
+refs/heads/master: 6f6c4dc040a6b4cbed02a57a78f5d08a86d84a38
diff --git a/trunk/drivers/staging/rts5139/TODO b/trunk/drivers/staging/rts5139/TODO
@@ -2,4 +2,8 @@ TODO:
 - support more USB card reader of Realtek family
 - use kernel coding style
 - checkpatch.pl fixes
-
+- stop having thousands of lines of code duplicated with staging/rts_pstor
+- This driver contains an entire SD/MMC stack -- it should use the stack in
+  drivers/mmc instead, as a host driver e.g. drivers/mmc/host/realtek-usb.c;
+  see drivers/mmc/host/ushc.c as an example.
+- This driver presents cards as SCSI devices, but they should be MMC devices.
diff --git a/trunk/drivers/staging/rts_pstor/TODO b/trunk/drivers/staging/rts_pstor/TODO
@@ -2,4 +2,8 @@ TODO:
 - support more pcie card reader of Realtek family
 - use kernel coding style
 - checkpatch.pl fixes
-
+- stop having thousands of lines of code duplicated with staging/rts5139
+- This driver contains an entire SD/MMC stack -- it should use the stack in
+  drivers/mmc instead, as a host driver e.g. drivers/mmc/host/realtek-pci.c;
+  see drivers/mmc/host/via-sdmmc.c as an example.
+- This driver presents cards as SCSI devices, but they should be MMC devices.