Skip to content

Commit

Permalink
sky2: program proper register for fiber PHY
Browse files Browse the repository at this point in the history
Driver was reading value from one register, setting bit and then
writing the wrong register.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Stephen Hemminger authored and Jeff Garzik committed May 30, 2007
1 parent 56069c0 commit 34dd962
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ static void sky2_phy_init(struct sky2_hw *hw, unsigned port)
/* for SFP-module set SIGDET polarity to low */
ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
ctrl |= PHY_M_FIB_SIGD_POL;
gm_phy_write(hw, port, PHY_MARV_CTRL, ctrl);
gm_phy_write(hw, port, PHY_MARV_PHY_CTRL, ctrl);
}

gm_phy_write(hw, port, PHY_MARV_EXT_ADR, pg);
Expand Down

0 comments on commit 34dd962

Please sign in to comment.