---

yaml --- r: 178015 b: refs/heads/master c: 7cf7db8 h: refs/heads/master i: 178013: ba0fbd1 178011: 59ba0cb 178007: 5fc8317 177999: 947aeb6 177983: 8e90e2f v: v3
git-mirror · Dec 10, 2009 · 34f0146 · 34f0146
1 parent 65125c2
commit 34f0146
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 14d8c9f3c09e7fd7b9af80904289fe204f5b93c6
+refs/heads/master: 7cf7db8df0b78076eafa4ead47559344ca7b7a43
diff --git a/trunk/kernel/signal.c b/trunk/kernel/signal.c
@@ -218,13 +218,13 @@ __sigqueue_alloc(int sig, struct task_struct *t, gfp_t flags, int override_rlimi
 	struct user_struct *user;
 
 	/*
-	 * We won't get problems with the target's UID changing under us
-	 * because changing it requires RCU be used, and if t != current, the
-	 * caller must be holding the RCU readlock (by way of a spinlock) and
-	 * we use RCU protection here
+	 * Protect access to @t credentials. This can go away when all
+	 * callers hold rcu read lock.
 	 */
+	rcu_read_lock();
 	user = get_uid(__task_cred(t)->user);
 	atomic_inc(&user->sigpending);
+	rcu_read_unlock();
 
 	if (override_rlimit ||
 	    atomic_read(&user->sigpending) <=