Skip to content

Commit

Permalink
ASoC: wm8994: Don't test for NULL before release_firmware()
Browse files Browse the repository at this point in the history
release_firmware() does its own NULL ptr testing, it's redundant to
also test before calling it.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Jesper Juhl authored and Mark Brown committed Apr 10, 2012
1 parent bbdd391 commit 34ff0f9
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions sound/soc/codecs/wm8994.c
Original file line number Diff line number Diff line change
Expand Up @@ -3936,7 +3936,7 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec)
return ret;
}

static int wm8994_codec_remove(struct snd_soc_codec *codec)
static int wm8994_codec_remove(struct snd_soc_codec *codec)
{
struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
struct wm8994 *control = wm8994->wm8994;
Expand Down Expand Up @@ -3977,14 +3977,10 @@ static int wm8994_codec_remove(struct snd_soc_codec *codec)
free_irq(wm8994->micdet_irq, wm8994);
break;
}
if (wm8994->mbc)
release_firmware(wm8994->mbc);
if (wm8994->mbc_vss)
release_firmware(wm8994->mbc_vss);
if (wm8994->enh_eq)
release_firmware(wm8994->enh_eq);
release_firmware(wm8994->mbc);
release_firmware(wm8994->mbc_vss);
release_firmware(wm8994->enh_eq);
kfree(wm8994->retune_mobile_texts);

return 0;
}

Expand Down

0 comments on commit 34ff0f9

Please sign in to comment.