Skip to content

Commit

Permalink
[PATCH] x86_64: Don't enable interrupt unconditionally in reboot path
Browse files Browse the repository at this point in the history
When they were disabled before (e.g. after a panic) it's better
to keep them off, otherwise followon panics can happen from timer
interrupt handlers etc.

Drawback is that pageup in the console won't work anymore though.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Nov 15, 2005
1 parent a88cde1 commit 3506229
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions arch/x86_64/kernel/reboot.c
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ static inline void kb_wait(void)

void machine_shutdown(void)
{
unsigned long flags;
/* Stop the cpus and apics */
#ifdef CONFIG_SMP
int reboot_cpu_id;
Expand All @@ -98,15 +99,15 @@ void machine_shutdown(void)
smp_send_stop();
#endif

local_irq_disable();
local_irq_save(flags);

#ifndef CONFIG_SMP
disable_local_APIC();
#endif

disable_IO_APIC();

local_irq_enable();
local_irq_restore(flags);
}

void machine_emergency_restart(void)
Expand Down
5 changes: 3 additions & 2 deletions arch/x86_64/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -450,13 +450,14 @@ int smp_call_function (void (*func) (void *info), void *info, int nonatomic,

void smp_stop_cpu(void)
{
unsigned long flags;
/*
* Remove this CPU:
*/
cpu_clear(smp_processor_id(), cpu_online_map);
local_irq_disable();
local_irq_save(flags);
disable_local_APIC();
local_irq_enable();
local_irq_restore(flags);
}

static void smp_really_stop_cpu(void *dummy)
Expand Down

0 comments on commit 3506229

Please sign in to comment.