Skip to content

Commit

Permalink
enic: bug fix: included MAC drops in rx_dropped netstat
Browse files Browse the repository at this point in the history
Bug fix: included MAC drops in rx_dropped netstat.  Also track Rx trunctations
stat at the MAC

Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Scott Feldman authored and David S. Miller committed Sep 4, 2009
1 parent 56ac88b commit 350991e
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions drivers/net/enic/enic.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ struct enic {
____cacheline_aligned struct vnic_rq rq[1];
unsigned int rq_count;
int (*rq_alloc_buf)(struct vnic_rq *rq);
u64 rq_truncated_pkts;
u64 rq_bad_fcs;
struct napi_struct napi;
struct net_lro_mgr lro_mgr;
Expand Down
11 changes: 8 additions & 3 deletions drivers/net/enic/enic_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -738,8 +738,9 @@ static struct net_device_stats *enic_get_stats(struct net_device *netdev)
net_stats->rx_bytes = stats->rx.rx_bytes_ok;
net_stats->rx_errors = stats->rx.rx_errors;
net_stats->multicast = stats->rx.rx_multicast_frames_ok;
net_stats->rx_over_errors = enic->rq_truncated_pkts;
net_stats->rx_crc_errors = enic->rq_bad_fcs;
net_stats->rx_dropped = stats->rx.rx_no_bufs;
net_stats->rx_dropped = stats->rx.rx_no_bufs + stats->rx.rx_drop;

return net_stats;
}
Expand Down Expand Up @@ -1029,8 +1030,12 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq,

if (packet_error) {

if (bytes_written > 0 && !fcs_ok)
enic->rq_bad_fcs++;
if (!fcs_ok) {
if (bytes_written > 0)
enic->rq_bad_fcs++;
else if (bytes_written == 0)
enic->rq_truncated_pkts++;
}

dev_kfree_skb_any(skb);

Expand Down

0 comments on commit 350991e

Please sign in to comment.