Skip to content

Commit

Permalink
Staging: hv: blkvsc_drv: Get rid of the indirection for removing stor…
Browse files Browse the repository at this point in the history
… device

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <v-abkane@microsoft.com>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed May 11, 2011
1 parent cb706b0 commit 3530ef3
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/staging/hv/blkvsc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ static int blk_vsc_initialize(struct hv_driver *driver)
stor_driver->max_outstanding_req_per_channel);

/* Setup the dispatch table */
stor_driver->base.dev_rm = storvsc_dev_remove;
stor_driver->base.cleanup = stor_vsc_on_cleanup;
stor_driver->on_io_request = stor_vsc_on_io_request;

Expand Down Expand Up @@ -543,16 +542,14 @@ static int blkvsc_cancel_pending_reqs(struct block_device_context *blkdev)
*/
static int blkvsc_remove(struct hv_device *dev)
{
struct storvsc_driver *storvsc_drv =
drv_to_stordrv(dev->device.driver);
struct block_device_context *blkdev = dev_get_drvdata(&dev->device);
unsigned long flags;

/*
* Call to the vsc driver to let it know that the device is being
* removed
*/
storvsc_drv->base.dev_rm(dev);
storvsc_dev_remove(dev);

/* Get to a known state */
spin_lock_irqsave(&blkdev->lock, flags);
Expand Down Expand Up @@ -934,9 +931,6 @@ static void blkvsc_drv_exit(void)
*/
static int blkvsc_probe(struct hv_device *dev)
{
struct storvsc_driver *storvsc_drv =
drv_to_stordrv(dev->device.driver);

struct block_device_context *blkdev = NULL;
struct storvsc_device_info device_info;
struct storvsc_major_info major_info;
Expand Down Expand Up @@ -1033,7 +1027,7 @@ static int blkvsc_probe(struct hv_device *dev)
return ret;

remove:
storvsc_drv->base.dev_rm(dev);
storvsc_dev_remove(dev);

cleanup:
if (blkdev) {
Expand Down

0 comments on commit 3530ef3

Please sign in to comment.