Skip to content

Commit

Permalink
drivers/net/wan: Adjust confusing if indentation
Browse files Browse the repository at this point in the history
Indent the branch of an if.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
  cocci.print_main("branch",p1)
  cocci.print_secs("after",p2)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Krzysztof Hałasa <khc@pm.waw.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Aug 17, 2010
1 parent 1565c7c commit 354c8e3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/net/wan/c101.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ static int c101_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
return -EINVAL; /* No such clock setting */
return -EINVAL; /* No such clock setting */

if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wan/n2.c
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ static int n2_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
return -EINVAL; /* No such clock setting */
return -EINVAL; /* No such clock setting */

if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wan/pci200syn.c
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ static int pci200_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
new_line.clock_type != CLOCK_TXFROMRX &&
new_line.clock_type != CLOCK_INT &&
new_line.clock_type != CLOCK_TXINT)
return -EINVAL; /* No such clock setting */
return -EINVAL; /* No such clock setting */

if (new_line.loopback != 0 && new_line.loopback != 1)
return -EINVAL;
Expand Down

0 comments on commit 354c8e3

Please sign in to comment.