Skip to content

Commit

Permalink
ASoC: jz4740-codec: Use devm_request_and_ioremap
Browse files Browse the repository at this point in the history
Use devm_request_and_ioremap for requesting and mapping the IO region. This
makes the code a bit smaller and simpler.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Lars-Peter Clausen authored and Mark Brown committed Oct 27, 2012
1 parent a484a9a commit 355d74b
Showing 1 changed file with 4 additions and 37 deletions.
41 changes: 4 additions & 37 deletions sound/soc/codecs/jz4740.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ static const uint32_t jz4740_codec_regs[] = {

struct jz4740_codec {
void __iomem *base;
struct resource *mem;
};

static unsigned int jz4740_codec_read(struct snd_soc_codec *codec,
Expand Down Expand Up @@ -371,56 +370,24 @@ static int __devinit jz4740_codec_probe(struct platform_device *pdev)
return -ENOMEM;

mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!mem) {
dev_err(&pdev->dev, "Failed to get mmio memory resource\n");
ret = -ENOENT;
goto err_out;
}

mem = request_mem_region(mem->start, resource_size(mem), pdev->name);
if (!mem) {
dev_err(&pdev->dev, "Failed to request mmio memory region\n");
ret = -EBUSY;
goto err_out;
}

jz4740_codec->base = ioremap(mem->start, resource_size(mem));
if (!jz4740_codec->base) {
dev_err(&pdev->dev, "Failed to ioremap mmio memory\n");
ret = -EBUSY;
goto err_release_mem_region;
}
jz4740_codec->mem = mem;
jz4740_codec->base = devm_request_and_ioremap(&pdev->dev, mem);
if (!jz4740_codec->base)
return -EBUSY;

platform_set_drvdata(pdev, jz4740_codec);

ret = snd_soc_register_codec(&pdev->dev,
&soc_codec_dev_jz4740_codec, &jz4740_codec_dai, 1);
if (ret) {
if (ret)
dev_err(&pdev->dev, "Failed to register codec\n");
goto err_iounmap;
}

return 0;

err_iounmap:
iounmap(jz4740_codec->base);
err_release_mem_region:
release_mem_region(mem->start, resource_size(mem));
err_out:
return ret;
}

static int __devexit jz4740_codec_remove(struct platform_device *pdev)
{
struct jz4740_codec *jz4740_codec = platform_get_drvdata(pdev);
struct resource *mem = jz4740_codec->mem;

snd_soc_unregister_codec(&pdev->dev);

iounmap(jz4740_codec->base);
release_mem_region(mem->start, resource_size(mem));

platform_set_drvdata(pdev, NULL);

return 0;
Expand Down

0 comments on commit 355d74b

Please sign in to comment.