Skip to content

Commit

Permalink
i2c-piix4: Minor cleanups
Browse files Browse the repository at this point in the history
* Remove a needless include.
* Remove a legacy comment in piix4_access.
* Minor optimization in piix4_access.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
  • Loading branch information
Jean Delvare authored and Jean Delvare committed Apr 29, 2008
1 parent c5d21b7 commit 3578a07
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions drivers/i2c/busses/i2c-piix4.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
#include <linux/ioport.h>
#include <linux/i2c.h>
#include <linux/init.h>
#include <linux/apm_bios.h>
#include <linux/dmi.h>
#include <asm/io.h>

Expand Down Expand Up @@ -343,12 +342,7 @@ static s32 piix4_access(struct i2c_adapter * adap, u16 addr,


switch (size) {
case PIIX4_BYTE: /* Where is the result put? I assume here it is in
SMBHSTDAT0 but it might just as well be in the
SMBHSTCMD. No clue in the docs */

data->byte = inb_p(SMBHSTDAT0);
break;
case PIIX4_BYTE:
case PIIX4_BYTE_DATA:
data->byte = inb_p(SMBHSTDAT0);
break;
Expand Down

0 comments on commit 3578a07

Please sign in to comment.