Skip to content

Commit

Permalink
sfc: QT202x: Remove unreliable MMD check at initialisation
Browse files Browse the repository at this point in the history
Checking the PHY XS MMD here is unnecessary and can give false negatives.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Matthew Slattery authored and David S. Miller committed Jan 19, 2010
1 parent 3469242 commit 357d46a
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/net/sfc/qt202x_phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,6 @@ static int qt202x_reset_phy(struct efx_nic *efx)
/* Wait 250ms for the PHY to complete bootup */
msleep(250);

/* Check that all the MMDs we expect are present and responding. We
* expect faults on some if the link is down, but not on the PHY XS */
rc = efx_mdio_check_mmds(efx, QT202X_REQUIRED_DEVS, MDIO_DEVS_PHYXS);
if (rc < 0)
goto fail;

falcon_board(efx)->type->init_phy(efx);

return rc;
Expand Down

0 comments on commit 357d46a

Please sign in to comment.