Skip to content

Commit

Permalink
intelfb: fixup pitch calculation like X does
Browse files Browse the repository at this point in the history
Signed-off-by: Dave Airlie <airlied@linux.ie>
  • Loading branch information
Dave Airlie committed Apr 3, 2006
1 parent 3aff13c commit 3587c50
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
17 changes: 17 additions & 0 deletions drivers/video/intelfb/intelfbdrv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1164,16 +1164,33 @@ intelfb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
struct fb_var_screeninfo v;
struct intelfb_info *dinfo;
static int first = 1;
int i;
/* Good pitches to allow tiling. Don't care about pitches < 1024. */
static const int pitches[] = {
128 * 8,
128 * 16,
128 * 32,
128 * 64,
0
};

DBG_MSG("intelfb_check_var: accel_flags is %d\n", var->accel_flags);

dinfo = GET_DINFO(info);

/* update the pitch */
if (intelfbhw_validate_mode(dinfo, var) != 0)
return -EINVAL;

v = *var;

for (i = 0; pitches[i] != 0; i++) {
if (pitches[i] >= v.xres_virtual) {
v.xres_virtual = pitches[i];
break;
}
}

/* Check for a supported bpp. */
if (v.bits_per_pixel <= 8) {
v.bits_per_pixel = 8;
Expand Down
2 changes: 1 addition & 1 deletion drivers/video/intelfb/intelfbhw.c
Original file line number Diff line number Diff line change
Expand Up @@ -1210,7 +1210,7 @@ intelfbhw_mode_to_hw(struct intelfb_info *dinfo, struct intelfb_hwstate *hw,
*ss = (hactive << SRC_SIZE_HORIZ_SHIFT) |
(vactive << SRC_SIZE_VERT_SHIFT);

hw->disp_a_stride = var->xres_virtual * var->bits_per_pixel / 8;
hw->disp_a_stride = dinfo->pitch;
DBG_MSG("pitch is %d\n", hw->disp_a_stride);

hw->disp_a_base = hw->disp_a_stride * var->yoffset +
Expand Down

0 comments on commit 3587c50

Please sign in to comment.