Skip to content

Commit

Permalink
sparc64: Fix section mis-match errors.
Browse files Browse the repository at this point in the history
Fix all of the problems spotted by CONFIG_DEBUG_SECTION_MISMATCH under
arch/sparc during a 64-bit defconfig build.

They fall into two categorites:

1) of_device_id is marked as __initdata, and we can never do this
   since these objects sit in the device core data structures way
   past boot.  So even if a driver will never be reloaded, we have
   to keep the device ID table around.

   Mark such cases const instead.

2) The bootmem alloc/free handling code in mdesc.c was not fully
   marked __init as it should be, thus generating a reference
   to free_bootmem_late() (which is __init) from non-__init code.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Mar 31, 2011
1 parent c897dcf commit 3628aa0
Show file tree
Hide file tree
Showing 11 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion arch/sparc/kernel/auxio_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ void auxio_set_lte(int on)
}
EXPORT_SYMBOL(auxio_set_lte);

static struct of_device_id __initdata auxio_match[] = {
static const struct of_device_id auxio_match[] = {
{
.name = "auxio",
},
Expand Down
4 changes: 2 additions & 2 deletions arch/sparc/kernel/central.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ static int __devinit clock_board_probe(struct platform_device *op)
goto out;
}

static struct of_device_id __initdata clock_board_match[] = {
static const struct of_device_id clock_board_match[] = {
{
.name = "clock-board",
},
Expand Down Expand Up @@ -245,7 +245,7 @@ static int __devinit fhc_probe(struct platform_device *op)
goto out;
}

static struct of_device_id __initdata fhc_match[] = {
static const struct of_device_id fhc_match[] = {
{
.name = "fhc",
},
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/ds.c
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,7 @@ static int ds_remove(struct vio_dev *vdev)
return 0;
}

static struct vio_device_id __initdata ds_match[] = {
static const struct vio_device_id ds_match[] = {
{
.type = "domain-services-port",
},
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/mdesc.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ static struct mdesc_handle * __init mdesc_memblock_alloc(unsigned int mdesc_size
return hp;
}

static void mdesc_memblock_free(struct mdesc_handle *hp)
static void __init mdesc_memblock_free(struct mdesc_handle *hp)
{
unsigned int alloc_size;
unsigned long start;
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/pci_fire.c
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ static int __devinit fire_probe(struct platform_device *op)
return err;
}

static struct of_device_id __initdata fire_match[] = {
static const struct of_device_id fire_match[] = {
{
.name = "pci",
.compatible = "pciex108e,80f0",
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/pci_psycho.c
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ static int __devinit psycho_probe(struct platform_device *op)
return err;
}

static struct of_device_id __initdata psycho_match[] = {
static const struct of_device_id psycho_match[] = {
{
.name = "pci",
.compatible = "pci108e,8000",
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/pci_sabre.c
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ static int __devinit sabre_probe(struct platform_device *op)
return err;
}

static struct of_device_id __initdata sabre_match[] = {
static const struct of_device_id sabre_match[] = {
{
.name = "pci",
.compatible = "pci108e,a001",
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/pci_schizo.c
Original file line number Diff line number Diff line change
Expand Up @@ -1470,7 +1470,7 @@ static int __devinit schizo_probe(struct platform_device *op)
* and pci108e,8001. So list the chips in reverse chronological
* order.
*/
static struct of_device_id __initdata schizo_match[] = {
static const struct of_device_id schizo_match[] = {
{
.name = "pci",
.compatible = "pci108e,a801",
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/pci_sun4v.c
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,7 @@ static int __devinit pci_sun4v_probe(struct platform_device *op)
return err;
}

static struct of_device_id __initdata pci_sun4v_match[] = {
static const struct of_device_id pci_sun4v_match[] = {
{
.name = "pci",
.compatible = "SUNW,sun4v-pci",
Expand Down
2 changes: 1 addition & 1 deletion arch/sparc/kernel/power.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ static int __devinit power_probe(struct platform_device *op)
return 0;
}

static struct of_device_id __initdata power_match[] = {
static const struct of_device_id power_match[] = {
{
.name = "power",
},
Expand Down
6 changes: 3 additions & 3 deletions arch/sparc/kernel/time_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ static int __devinit rtc_probe(struct platform_device *op)
return platform_device_register(&rtc_cmos_device);
}

static struct of_device_id __initdata rtc_match[] = {
static const struct of_device_id rtc_match[] = {
{
.name = "rtc",
.compatible = "m5819",
Expand Down Expand Up @@ -487,7 +487,7 @@ static int __devinit bq4802_probe(struct platform_device *op)
return platform_device_register(&rtc_bq4802_device);
}

static struct of_device_id __initdata bq4802_match[] = {
static const struct of_device_id bq4802_match[] = {
{
.name = "rtc",
.compatible = "bq4802",
Expand Down Expand Up @@ -552,7 +552,7 @@ static int __devinit mostek_probe(struct platform_device *op)
return platform_device_register(&m48t59_rtc);
}

static struct of_device_id __initdata mostek_match[] = {
static const struct of_device_id mostek_match[] = {
{
.name = "eeprom",
},
Expand Down

0 comments on commit 3628aa0

Please sign in to comment.