Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 212217
b: refs/heads/master
c: ad9f433
h: refs/heads/master
i:
  212215: 7f8a725
v: v3
  • Loading branch information
Thomas Gleixner committed Oct 12, 2010
1 parent 10081cd commit 36480f2
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 48b2650196364e4ef124efb841b63c2326e4ccb2
refs/heads/master: ad9f43340f48c5f7a0a5ef7656986e23d06bf996
22 changes: 10 additions & 12 deletions trunk/arch/x86/kernel/apic/io_apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,6 @@ void __setup_vector_irq(int cpu)
/* Initialize vector_irq on a new cpu */
int irq, vector;
struct irq_cfg *cfg;
struct irq_desc *desc;

/*
* vector_lock will make sure that we don't run into irq vector
Expand All @@ -1169,9 +1168,10 @@ void __setup_vector_irq(int cpu)
*/
raw_spin_lock(&vector_lock);
/* Mark the inuse vectors */
for_each_irq_desc(irq, desc) {
cfg = get_irq_desc_chip_data(desc);

for_each_active_irq(irq) {
cfg = get_irq_chip_data(irq);
if (!cfg)
continue;
/*
* If it is a legacy IRQ handled by the legacy PIC, this cpu
* will be part of the irq_cfg's domain.
Expand Down Expand Up @@ -1516,7 +1516,6 @@ __apicdebuginit(void) print_IO_APIC(void)
union IO_APIC_reg_03 reg_03;
unsigned long flags;
struct irq_cfg *cfg;
struct irq_desc *desc;
unsigned int irq;

printk(KERN_DEBUG "number of MP IRQ sources: %d.\n", mp_irq_entries);
Expand Down Expand Up @@ -1603,10 +1602,10 @@ __apicdebuginit(void) print_IO_APIC(void)
}
}
printk(KERN_DEBUG "IRQ to pin mappings:\n");
for_each_irq_desc(irq, desc) {
for_each_active_irq(irq) {
struct irq_pin_list *entry;

cfg = get_irq_desc_chip_data(desc);
cfg = get_irq_chip_data(irq);
if (!cfg)
continue;
entry = cfg->irq_2_pin;
Expand Down Expand Up @@ -2574,9 +2573,8 @@ static struct irq_chip ir_ioapic_chip __read_mostly = {

static inline void init_IO_APIC_traps(void)
{
int irq;
struct irq_desc *desc;
struct irq_cfg *cfg;
unsigned int irq;

/*
* NOTE! The local APIC isn't very good at handling
Expand All @@ -2589,8 +2587,8 @@ static inline void init_IO_APIC_traps(void)
* Also, we've got to be careful not to trash gate
* 0x80, because int 0x80 is hm, kind of importantish. ;)
*/
for_each_irq_desc(irq, desc) {
cfg = get_irq_desc_chip_data(desc);
for_each_active_irq(irq) {
cfg = get_irq_chip_data(irq);
if (IO_APIC_IRQ(irq) && cfg && !cfg->vector) {
/*
* Hmm.. We don't have an entry for this,
Expand All @@ -2601,7 +2599,7 @@ static inline void init_IO_APIC_traps(void)
legacy_pic->make_irq(irq);
else
/* Strange. Oh, well.. */
desc->chip = &no_irq_chip;
set_irq_chip(irq, &no_irq_chip);
}
}
}
Expand Down

0 comments on commit 36480f2

Please sign in to comment.