Skip to content

Commit

Permalink
ppc: fix AT_VECTOR_SIZE on arch/ppc
Browse files Browse the repository at this point in the history
Commit 4f9a58d ("increase
AT_VECTOR_SIZE to terminate saved_auxv properly") changes the size of
AT_VECTOR_SIZE from hard coded '44' to a calculation based on the value
of AT_VECTOR_SIZE_ARCH and AT_VECTOR_SIZE_BASE.

The change works for arch/powerpc, but it breaks arch/ppc because the
needed AT_VECTOR_SIZE_ARCH is not present in include/asm-ppc/system.h
and a default value of 0 is used instead.  This results in
AT_VECTOR_SIZE being too small and it causes a kernel crash on loading
init.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Grant Likely authored and Linus Torvalds committed Oct 23, 2007
1 parent 527da38 commit 3650b0a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions include/asm-ppc/system.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

#define set_mb(var, value) do { var = value; mb(); } while (0)

#define AT_VECTOR_SIZE_ARCH 6 /* entries in ARCH_DLINFO */
#ifdef CONFIG_SMP
#define smp_mb() mb()
#define smp_rmb() rmb()
Expand Down

0 comments on commit 3650b0a

Please sign in to comment.