Skip to content

Commit

Permalink
[TIPC]: Improve socket time conversions
Browse files Browse the repository at this point in the history
This patch modifies TIPC's socket code to use standard kernel
routines to handle time conversions between jiffies and ms.
This ensures proper operation even when HZ isn't 1000.

Acknowledgements to Eric Sesterhenn <snakebyte@gmx.de> for
identifying this issue and proposing a solution.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Allan Stephens authored and David S. Miller committed Apr 14, 2008
1 parent 9673693 commit 3654ea0
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions net/tipc/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@
#define SS_LISTENING -1 /* socket is listening */
#define SS_READY -2 /* socket is connectionless */

#define OVERLOAD_LIMIT_BASE 5000
#define OVERLOAD_LIMIT_BASE 5000
#define CONN_TIMEOUT_DEFAULT 8000 /* default connect timeout = 8s */

struct tipc_sock {
struct sock sk;
Expand Down Expand Up @@ -170,7 +171,7 @@ static int tipc_create(struct net *net, struct socket *sock, int protocol)
}

sock_init_data(sock, sk);
sk->sk_rcvtimeo = 8 * HZ; /* default connect timeout = 8s */
sk->sk_rcvtimeo = msecs_to_jiffies(CONN_TIMEOUT_DEFAULT);

tsock = tipc_sk(sk);
port = tipc_get_port(ref);
Expand Down Expand Up @@ -1529,7 +1530,7 @@ static int setsockopt(struct socket *sock,
res = tipc_set_portunreturnable(tsock->p->ref, value);
break;
case TIPC_CONN_TIMEOUT:
sock->sk->sk_rcvtimeo = (value * HZ / 1000);
sock->sk->sk_rcvtimeo = msecs_to_jiffies(value);
break;
default:
res = -EINVAL;
Expand Down Expand Up @@ -1582,7 +1583,7 @@ static int getsockopt(struct socket *sock,
res = tipc_portunreturnable(tsock->p->ref, &value);
break;
case TIPC_CONN_TIMEOUT:
value = (sock->sk->sk_rcvtimeo * 1000) / HZ;
value = jiffies_to_msecs(sock->sk->sk_rcvtimeo);
break;
default:
res = -EINVAL;
Expand Down

0 comments on commit 3654ea0

Please sign in to comment.