Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 153676
b: refs/heads/master
c: e300a63
h: refs/heads/master
v: v3
  • Loading branch information
J. Bruce Fields committed Apr 29, 2009
1 parent aacf6e0 commit 3676ff6
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 17 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3cef9ab266a932899e756f7e1ea7a988a97bf3b2
refs/heads/master: e300a63ce4ccec073d254d883a3638d5dca1d771
38 changes: 22 additions & 16 deletions trunk/fs/nfsd/nfs4callback.c
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,21 @@ static void warn_no_callback_path(struct nfs4_client *clp, int reason)
(int)clp->cl_name.len, clp->cl_name.data, reason);
}

static void nfsd4_cb_probe_done(struct rpc_task *task, void *calldata)
{
struct nfs4_client *clp = calldata;

if (task->tk_status)
warn_no_callback_path(clp, task->tk_status);
else
atomic_set(&clp->cl_callback.cb_set, 1);
put_nfs4_client(clp);
}

static const struct rpc_call_ops nfsd4_cb_probe_ops = {
.rpc_call_done = nfsd4_cb_probe_done,
};

static struct rpc_cred *lookup_cb_cred(struct nfs4_callback *cb)
{
struct auth_cred acred = {
Expand All @@ -431,9 +446,8 @@ static struct rpc_cred *lookup_cb_cred(struct nfs4_callback *cb)
RPCAUTH_LOOKUP_NEW);
}

static int do_probe_callback(void *data)
void do_probe_callback(struct nfs4_client *clp)
{
struct nfs4_client *clp = data;
struct nfs4_callback *cb = &clp->cl_callback;
struct rpc_message msg = {
.rpc_proc = &nfs4_cb_procedures[NFSPROC4_CLNT_CB_NULL],
Expand All @@ -449,15 +463,13 @@ static int do_probe_callback(void *data)
}
cb->cb_cred = cred;
msg.rpc_cred = cb->cb_cred;
status = rpc_call_sync(cb->cb_client, &msg, RPC_TASK_SOFT);
status = rpc_call_async(cb->cb_client, &msg, RPC_TASK_SOFT,
&nfsd4_cb_probe_ops, (void *)clp);
out:
if (status)
if (status) {
warn_no_callback_path(clp, status);
else
atomic_set(&cb->cb_set, 1);

put_nfs4_client(clp);
return 0;
put_nfs4_client(clp);
}
}

/*
Expand All @@ -466,7 +478,6 @@ static int do_probe_callback(void *data)
void
nfsd4_probe_callback(struct nfs4_client *clp)
{
struct task_struct *t;
int status;

BUG_ON(atomic_read(&clp->cl_callback.cb_set));
Expand All @@ -480,12 +491,7 @@ nfsd4_probe_callback(struct nfs4_client *clp)
/* the task holds a reference to the nfs4_client struct */
atomic_inc(&clp->cl_count);

t = kthread_run(do_probe_callback, clp, "nfs4_cb_probe");

if (IS_ERR(t))
atomic_dec(&clp->cl_count);

return;
do_probe_callback(clp);
}

/*
Expand Down

0 comments on commit 3676ff6

Please sign in to comment.