Skip to content

Commit

Permalink
ide: fix pre-EIDE SWDMA support on big-endian
Browse files Browse the repository at this point in the history
id->tDMA is of 'unsigned char' type so endianness is already
correct and calling le16_to_cpu() is wrong.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Aug 5, 2008
1 parent ca5de40 commit 367fdcb
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/ide/ide-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -649,11 +649,7 @@ static unsigned int ide_get_mode_mask(ide_drive_t *drive, u8 base, u8 req_mode)
if (id->field_valid & 2) {
mask = id->dma_1word & hwif->swdma_mask;
} else if (id->tDMA) {
/*
* ide_fix_driveid() doesn't convert ->tDMA to the
* CPU endianness so we need to do it here
*/
u8 mode = le16_to_cpu(id->tDMA);
u8 mode = id->tDMA;

/*
* if the mode is valid convert it to the mask
Expand Down

0 comments on commit 367fdcb

Please sign in to comment.