Skip to content

Commit

Permalink
iscsi-target: fix extract_param to handle buffer length corner case
Browse files Browse the repository at this point in the history
extract_param() is called with max_length set to the total size of the
output buffer.  It's not safe to allow a parameter length equal to the
buffer size as the terminating null would be written one byte past the
end of the output buffer.

Signed-off-by: Eric Seppanen <eric@purestorage.com>
Cc: <stable@vger.kernel.org> #3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Eric Seppanen authored and Nicholas Bellinger committed Nov 21, 2013
1 parent d1fa7a1 commit 369653e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/target/iscsi/iscsi_target_nego.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ int extract_param(
if (len < 0)
return -1;

if (len > max_length) {
if (len >= max_length) {
pr_err("Length of input: %d exceeds max_length:"
" %d\n", len, max_length);
return -1;
Expand Down

0 comments on commit 369653e

Please sign in to comment.