Skip to content

Commit

Permalink
iio: dac/ad5755: signedness bug in ad5755_setup_pdata()
Browse files Browse the repository at this point in the history
We need "ret" to be signed for the error handling to work correctly.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Dan Carpenter authored and Jonathan Cameron committed Sep 22, 2012
1 parent f07b60b commit 369d0e2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/iio/dac/ad5755.c
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,9 @@ static int __devinit ad5755_setup_pdata(struct iio_dev *indio_dev,
const struct ad5755_platform_data *pdata)
{
struct ad5755_state *st = iio_priv(indio_dev);
unsigned int ret;
unsigned int val;
unsigned int i;
int ret;

if (pdata->dc_dc_phase > AD5755_DC_DC_PHASE_90_DEGREE ||
pdata->dc_dc_freq > AD5755_DC_DC_FREQ_650kHZ ||
Expand Down

0 comments on commit 369d0e2

Please sign in to comment.