Skip to content

Commit

Permalink
staging: line6: drop MIDI dumping code
Browse files Browse the repository at this point in the history
ALSA amidi(1) and aseqdump(1) can be used to dump MIDI instead of
manually dumping MIDI messages in the driver.  The advantage of using
these existing tools is that can be used at run-time rather than
compile-time.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Stefan Hajnoczi authored and Greg Kroah-Hartman committed Nov 15, 2012
1 parent 4aea449 commit 36a01f4
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions drivers/staging/line6/driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,6 @@ static void line6_data_received(struct urb *urb)
continue;

line6->message_length = done;
#ifdef CONFIG_LINE6_USB_DUMP_MIDI
line6_write_hexdump(line6, 'r', line6->buffer_message, done);
#endif
line6_midi_receive(line6, line6->buffer_message, done);

switch (line6->usbdev->descriptor.idProduct) {
Expand Down
3 changes: 0 additions & 3 deletions drivers/staging/line6/midi.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@ static void line6_midi_transmit(struct snd_rawmidi_substream *substream)
if (done == 0)
break;

#ifdef CONFIG_LINE6_USB_DUMP_MIDI
line6_write_hexdump(line6, 's', chunk, done);
#endif
line6_midibuf_write(mb, chunk, done);
snd_rawmidi_transmit_ack(substream, done);
}
Expand Down

0 comments on commit 36a01f4

Please sign in to comment.