Skip to content

Commit

Permalink
drm/mgag200: Remove unecessary NULL check in bo_unref
Browse files Browse the repository at this point in the history
ttm_bo_unref unconditionally calls kref_put on it's argument, so the
thing can't be NULL without already causing Oopses.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Daniel Vetter committed Apr 22, 2014
1 parent a798c10 commit 36b347f
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/gpu/drm/mgag200/mgag200_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,7 @@ static void mgag200_bo_unref(struct mgag200_bo **bo)

tbo = &((*bo)->bo);
ttm_bo_unref(&tbo);
if (tbo == NULL)
*bo = NULL;

*bo = NULL;
}

void mgag200_gem_free_object(struct drm_gem_object *obj)
Expand Down

0 comments on commit 36b347f

Please sign in to comment.