Skip to content

Commit

Permalink
iio: adc: ad7266: Don't set error code to st->vref_uv
Browse files Browse the repository at this point in the history
regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to st->vref_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Axel Lin authored and Jonathan Cameron committed Dec 27, 2012
1 parent 9541cc3 commit 36ce0c1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/iio/adc/ad7266.c
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,11 @@ static int __devinit ad7266_probe(struct spi_device *spi)
if (ret)
goto error_put_reg;

st->vref_uv = regulator_get_voltage(st->reg);
ret = regulator_get_voltage(st->reg);
if (ret < 0)
goto error_disable_reg;

st->vref_uv = ret;
} else {
/* Use internal reference */
st->vref_uv = 2500000;
Expand Down

0 comments on commit 36ce0c1

Please sign in to comment.