Skip to content

Commit

Permalink
Blackfin: pm: drop irq save/restore in standby and suspend to mem cal…
Browse files Browse the repository at this point in the history
…lback

Since linux-2.6.31, the kernel suspend framework will do disable_irq/enable_irq,
so save/restore irq in standby and suspend to mem callback should be dropped.
Otherwise the common code notices things are enabled and complains.

Signed-off-by: Steven Miao <realmz6@gmail.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
  • Loading branch information
Steven Miao authored and Mike Frysinger committed Jan 10, 2011
1 parent 527a1a8 commit 36e11ab
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions arch/blackfin/mach-common/pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@

void bfin_pm_suspend_standby_enter(void)
{
unsigned long flags;

flags = hard_local_irq_save();
bfin_pm_standby_setup();

#ifdef CONFIG_PM_BFIN_SLEEP_DEEPER
Expand Down Expand Up @@ -55,8 +52,6 @@ void bfin_pm_suspend_standby_enter(void)
#else
bfin_write_SIC_IWR(IWR_DISABLE_ALL);
#endif

hard_local_irq_restore(flags);
}

int bf53x_suspend_l1_mem(unsigned char *memptr)
Expand Down Expand Up @@ -127,7 +122,6 @@ static void flushinv_all_dcache(void)

int bfin_pm_suspend_mem_enter(void)
{
unsigned long flags;
int wakeup, ret;

unsigned char *memptr = kmalloc(L1_CODE_LENGTH + L1_DATA_A_LENGTH
Expand All @@ -149,12 +143,9 @@ int bfin_pm_suspend_mem_enter(void)
wakeup |= GPWE;
#endif

flags = hard_local_irq_save();

ret = blackfin_dma_suspend();

if (ret) {
hard_local_irq_restore(flags);
kfree(memptr);
return ret;
}
Expand All @@ -178,7 +169,6 @@ int bfin_pm_suspend_mem_enter(void)
bfin_gpio_pm_hibernate_restore();
blackfin_dma_resume();

hard_local_irq_restore(flags);
kfree(memptr);

return 0;
Expand Down

0 comments on commit 36e11ab

Please sign in to comment.