Skip to content

Commit

Permalink
ata: Make pata_of_platform.c compile again and work on non-PPC platforms
Browse files Browse the repository at this point in the history
This patch adds missing #includes, makes the driver selectable on
non-PPC OF-enabled platforms and fixes property value accesses to
be correct in Little Endian system.

Cc: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Pawel Moll <pawel.moll@arm.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Pawel Moll authored and Jeff Garzik committed Oct 8, 2011
1 parent edc7d12 commit 37210fb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/ata/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -820,7 +820,7 @@ config PATA_PLATFORM

config PATA_OF_PLATFORM
tristate "OpenFirmware platform device PATA support"
depends on PATA_PLATFORM && PPC_OF
depends on PATA_PLATFORM && OF
help
This option enables support for generic directly connected ATA
devices commonly found on embedded systems with OpenFirmware
Expand Down
6 changes: 4 additions & 2 deletions drivers/ata/pata_of_platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@

#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <linux/ata_platform.h>

Expand Down Expand Up @@ -57,11 +59,11 @@ static int __devinit pata_of_platform_probe(struct platform_device *ofdev)

prop = of_get_property(dn, "reg-shift", NULL);
if (prop)
reg_shift = *prop;
reg_shift = be32_to_cpup(prop);

prop = of_get_property(dn, "pio-mode", NULL);
if (prop) {
pio_mode = *prop;
pio_mode = be32_to_cpup(prop);
if (pio_mode > 6) {
dev_err(&ofdev->dev, "invalid pio-mode\n");
return -EINVAL;
Expand Down

0 comments on commit 37210fb

Please sign in to comment.