Skip to content

Commit

Permalink
[SCSI] lpfc: Move a dereference below a NULL test
Browse files Browse the repository at this point in the history
In each case, if the NULL test is necessary, then the dereference should be
moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: James Smart <James.Smart@Emulex.Com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Julia Lawall authored and James Bottomley committed Jan 2, 2009
1 parent b99b4c6 commit 372bd28
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/scsi/lpfc/lpfc_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -1795,12 +1795,13 @@ lpfc_block_mgmt_io(struct lpfc_hba * phba)
int
lpfc_online(struct lpfc_hba *phba)
{
struct lpfc_vport *vport = phba->pport;
struct lpfc_vport *vport;
struct lpfc_vport **vports;
int i;

if (!phba)
return 0;
vport = phba->pport;

if (!(vport->fc_flag & FC_OFFLINE_MODE))
return 0;
Expand Down

0 comments on commit 372bd28

Please sign in to comment.