Skip to content

Commit

Permalink
cciss: Set the performant mode bit in the scsi half of the driver
Browse files Browse the repository at this point in the history
cciss: Set the performant mode bit in the scsi half of the driver
In a couple of places, the performant mode bit wasn't being set in
the scsi half of the driver, causing commands to seem to hang.  Use
enqueue_cmd_and_start_io() where appropriate.  This fixes a bug that

	echo engage scsi > /proc/driver/cciss/cciss0

would hang.

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
  • Loading branch information
Stephen M. Cameron authored and Jens Axboe committed Aug 7, 2010
1 parent d54142c commit 373b45f
Showing 1 changed file with 2 additions and 18 deletions.
20 changes: 2 additions & 18 deletions drivers/block/cciss_scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,6 @@ cciss_scsi_do_simple_cmd(ctlr_info_t *c,
unsigned char *buf, int bufsize,
int direction)
{
unsigned long flags;
DECLARE_COMPLETION_ONSTACK(wait);

cp->cmd_type = CMD_IOCTL_PEND; // treat this like an ioctl
Expand All @@ -948,14 +947,7 @@ cciss_scsi_do_simple_cmd(ctlr_info_t *c,
bufsize, DMA_FROM_DEVICE);

cp->waiting = &wait;

/* Put the request on the tail of the request queue */
spin_lock_irqsave(CCISS_LOCK(c->ctlr), flags);
addQ(&c->reqQ, cp);
c->Qdepth++;
start_io(c);
spin_unlock_irqrestore(CCISS_LOCK(c->ctlr), flags);

enqueue_cmd_and_start_io(c, cp);
wait_for_completion(&wait);

/* undo the dma mapping */
Expand Down Expand Up @@ -1525,15 +1517,7 @@ cciss_scsi_queue_command (struct scsi_cmnd *cmd, void (* done)(struct scsi_cmnd
break;
}
cciss_scatter_gather(c, cp, cmd);

/* Put the request on the tail of the request queue */

spin_lock_irqsave(CCISS_LOCK(ctlr), flags);
addQ(&c->reqQ, cp);
c->Qdepth++;
start_io(c);
spin_unlock_irqrestore(CCISS_LOCK(ctlr), flags);

enqueue_cmd_and_start_io(c, cp);
/* the cmd'll come back via intr handler in complete_scsi_command() */
return 0;
}
Expand Down

0 comments on commit 373b45f

Please sign in to comment.