Skip to content

Commit

Permalink
[AUDIT] Requeue messages at head of queue, up to audit_backlog
Browse files Browse the repository at this point in the history
If netlink_unicast() fails, requeue the skb back at the head of the queue
it just came from, instead of the tail. And do so unless we've exceeded
the audit_backlog limit; not according to some other arbitrary limit.

From: Chris Wright <chrisw@osdl.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
Chris Wright authored and Unknown committed Apr 29, 2005
1 parent c94c257 commit 37509e7
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions kernel/audit.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ struct audit_buffer {
int total;
int type;
int pid;
int count; /* Times requeued */
};

void audit_set_type(struct audit_buffer *ab, int type)
Expand Down Expand Up @@ -526,9 +525,9 @@ static inline int audit_log_drain(struct audit_buffer *ab)
retval = netlink_unicast(audit_sock, skb, audit_pid,
MSG_DONTWAIT);
}
if (retval == -EAGAIN && ab->count < 5) {
++ab->count;
skb_queue_tail(&ab->sklist, skb);
if (retval == -EAGAIN &&
(atomic_read(&audit_backlog)) < audit_backlog_limit) {
skb_queue_head(&ab->sklist, skb);
audit_log_end_irq(ab);
return 1;
}
Expand Down Expand Up @@ -666,7 +665,6 @@ struct audit_buffer *audit_log_start(struct audit_context *ctx)
ab->total = 0;
ab->type = AUDIT_KERNEL;
ab->pid = 0;
ab->count = 0;

#ifdef CONFIG_AUDITSYSCALL
if (ab->ctx)
Expand Down

0 comments on commit 37509e7

Please sign in to comment.