Skip to content

Commit

Permalink
Input: aiptek - kill aiptek_convert_from_2s_complement()
Browse files Browse the repository at this point in the history
There is no reason to do that, just tell the compiler that
we are dealing with signed values in buffer, that's it.

Signed-off-by: Rene van Paassen <rene.vanpaassen@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Dmitry Torokhov committed Jul 10, 2007
1 parent cd438a5 commit 37767b6
Showing 1 changed file with 2 additions and 22 deletions.
24 changes: 2 additions & 22 deletions drivers/input/tablet/aiptek.c
Original file line number Diff line number Diff line change
Expand Up @@ -376,26 +376,6 @@ static const char *map_val_to_str(const struct aiptek_map *map, int val)
return "unknown";
}

/***********************************************************************
* Relative reports deliver values in 2's complement format to
* deal with negative offsets.
*/
static int aiptek_convert_from_2s_complement(unsigned char c)
{
int ret;
unsigned char b = c;
int negate = 0;

if ((b & 0x80) != 0) {
b = ~b;
b--;
negate = 1;
}
ret = b;
ret = (negate == 1) ? -ret : ret;
return ret;
}

/***********************************************************************
* aiptek_irq can receive one of six potential reports.
* The documentation for each is in the body of the function.
Expand Down Expand Up @@ -473,8 +453,8 @@ static void aiptek_irq(struct urb *urb)
aiptek->diagnostic =
AIPTEK_DIAGNOSTIC_SENDING_RELATIVE_IN_ABSOLUTE;
} else {
x = aiptek_convert_from_2s_complement(data[2]);
y = aiptek_convert_from_2s_complement(data[3]);
x = (signed char) data[2];
y = (signed char) data[3];

/* jitterable keeps track of whether any button has been pressed.
* We're also using it to remap the physical mouse button mask
Expand Down

0 comments on commit 37767b6

Please sign in to comment.