---

yaml --- r: 9805 b: refs/heads/master c: 1bef400 h: refs/heads/master i: 9803: aefaf3f v: v3
git-mirror · Oct 11, 2005 · 37787ea · 37787ea
1 parent 66d644e
commit 37787ea
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 22c1ea44f0d33eda532883858b6cdabc5f265b66
+refs/heads/master: 1bef40032992320dd25a266fc166bfb8fa3f2f59
diff --git a/trunk/mm/madvise.c b/trunk/mm/madvise.c
@@ -83,6 +83,9 @@ static long madvise_willneed(struct vm_area_struct * vma,
 {
 	struct file *file = vma->vm_file;
 
+	if (!file)
+		return -EBADF;
+
 	if (file->f_mapping->a_ops->get_xip_page) {
 		/* no bad return value, but ignore advice */
 		return 0;
@@ -141,11 +144,7 @@ static long
 madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev,
 		unsigned long start, unsigned long end, int behavior)
 {
-	struct file *filp = vma->vm_file;
-	long error = -EBADF;
-
-	if (!filp)
-		goto  out;
+	long error;
 
 	switch (behavior) {
 	case MADV_NORMAL:
@@ -166,8 +165,6 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev,
 		error = -EINVAL;
 		break;
 	}
-
-out:
 	return error;
 }