Skip to content

Commit

Permalink
ne2k-pci: Do not register device until initialized.
Browse files Browse the repository at this point in the history
Doing it in reverse order causes uevent to be sent before
we have a MAC address, which confuses udev.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Lubomir Rintel authored and David S. Miller committed May 2, 2009
1 parent 902e5ea commit 379b026
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/net/ne2k-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -374,18 +374,17 @@ static int __devinit ne2k_pci_init_one (struct pci_dev *pdev,
dev->ethtool_ops = &ne2k_pci_ethtool_ops;
NS8390_init(dev, 0);

memcpy(dev->dev_addr, SA_prom, 6);
memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);

i = register_netdev(dev);
if (i)
goto err_out_free_netdev;

for(i = 0; i < 6; i++)
dev->dev_addr[i] = SA_prom[i];
printk("%s: %s found at %#lx, IRQ %d, %pM.\n",
dev->name, pci_clone_list[chip_idx].name, ioaddr, dev->irq,
dev->dev_addr);

memcpy(dev->perm_addr, dev->dev_addr, dev->addr_len);

return 0;

err_out_free_netdev:
Expand Down

0 comments on commit 379b026

Please sign in to comment.