Skip to content

Commit

Permalink
[SCSI] zfcp: Add port only once to FC transport class
Browse files Browse the repository at this point in the history
When calling fc_remote_port_add make sure to not call it again before
fc_remote_port_delete has been called. In other words, ensure to
create a new fc_rport, then delete it, then create a new one again.

Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Christof Schmitt authored and James Bottomley committed Jul 30, 2009
1 parent cbf1ed0 commit 379d6bf
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion drivers/s390/scsi/zfcp_scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,9 @@ static void zfcp_scsi_rport_register(struct zfcp_port *port)
struct fc_rport_identifiers ids;
struct fc_rport *rport;

if (port->rport)
return;

ids.node_name = port->wwnn;
ids.port_name = port->wwpn;
ids.port_id = port->d_id;
Expand All @@ -557,8 +560,10 @@ static void zfcp_scsi_rport_block(struct zfcp_port *port)
{
struct fc_rport *rport = port->rport;

if (rport)
if (rport) {
fc_remote_port_delete(rport);
port->rport = NULL;
}
}

void zfcp_scsi_schedule_rport_register(struct zfcp_port *port)
Expand Down

0 comments on commit 379d6bf

Please sign in to comment.