Skip to content

Commit

Permalink
drivers/net/irda: endianness, NULL noise
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Al Viro authored and David S. Miller committed Oct 10, 2007
1 parent c676504 commit 37e1370
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/net/irda/mcs7780.c
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ static void mcs_unwrap_fir(struct mcs_cb *mcs, __u8 *buf, int len)
}

fcs = ~(crc32_le(~0, buf, new_len));
if(fcs != le32_to_cpu(get_unaligned((u32 *)(buf+new_len)))) {
if(fcs != le32_to_cpu(get_unaligned((__le32 *)(buf+new_len)))) {
IRDA_ERROR("crc error calc 0x%x len %d\n", fcs, new_len);
mcs->stats.rx_errors++;
mcs->stats.rx_crc_errors++;
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/irda/sir_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ EXPORT_SYMBOL(sirdev_raw_read);
int sirdev_set_dtr_rts(struct sir_dev *dev, int dtr, int rts)
{
int ret = -ENXIO;
if (dev->drv->set_dtr_rts != 0)
if (dev->drv->set_dtr_rts)
ret = dev->drv->set_dtr_rts(dev, dtr, rts);
return ret;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/irda/stir4200.c
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ static void fir_eof(struct stir_cb *stir)
}

fcs = ~(crc32_le(~0, rx_buff->data, len));
if (fcs != le32_to_cpu(get_unaligned((u32 *)(rx_buff->data+len)))) {
if (fcs != le32_to_cpu(get_unaligned((__le32 *)(rx_buff->data+len)))) {
pr_debug("crc error calc 0x%x len %d\n", fcs, len);
stir->stats.rx_errors++;
stir->stats.rx_crc_errors++;
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/irda/vlsi_ir.h
Original file line number Diff line number Diff line change
Expand Up @@ -537,10 +537,10 @@ calc_width_bits(unsigned baudrate, unsigned widthselect, unsigned clockselect)
*/

struct ring_descr_hw {
volatile u16 rd_count; /* tx/rx count [11:0] */
u16 reserved;
volatile __le16 rd_count; /* tx/rx count [11:0] */
__le16 reserved;
union {
u32 addr; /* [23:0] of the buffer's busaddress */
__le32 addr; /* [23:0] of the buffer's busaddress */
struct {
u8 addr_res[3];
volatile u8 status; /* descriptor status */
Expand Down

0 comments on commit 37e1370

Please sign in to comment.