Skip to content

Commit

Permalink
hwmon: (adt7410) handle errors from adt7410_update_device()
Browse files Browse the repository at this point in the history
Smatch complains that adt7410_update_device() can return error pointers.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Dan Carpenter authored and Guenter Roeck committed Sep 24, 2012
1 parent 983b97b commit 37f9648
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions drivers/hwmon/adt7410.c
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,14 @@ static ssize_t adt7410_show_t_hyst(struct device *dev,
char *buf)
{
struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
struct adt7410_data *data = adt7410_update_device(dev);
struct adt7410_data *data;
int nr = attr->index;
int hyst = (data->hyst & ADT7410_T_HYST_MASK) * 1000;
int hyst;

data = adt7410_update_device(dev);
if (IS_ERR(data))
return PTR_ERR(data);
hyst = (data->hyst & ADT7410_T_HYST_MASK) * 1000;

/*
* hysteresis is stored as a 4 bit offset in the device, convert it
Expand Down

0 comments on commit 37f9648

Please sign in to comment.