Skip to content

Commit

Permalink
Blackfin arch: change return value
Browse files Browse the repository at this point in the history
change return of close_cplbtab() and fill_cplbtab() to void since we
always return 0 and nowhere do we check this

Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
  • Loading branch information
Mike Frysinger authored and Bryan Wu committed Nov 18, 2008
1 parent 4c5b8a6 commit 3831638
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions arch/blackfin/kernel/cplb-nompu/cplbinit.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
* to the Free Software Foundation, Inc.,
* 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/

#include <linux/module.h>

#include <asm/blackfin.h>
Expand Down Expand Up @@ -169,7 +170,7 @@ static bool __init lock_kernel_check(u32 start, u32 end)
return true;
}

static unsigned short __init
static void __init
fill_cplbtab(struct cplb_tab *table,
unsigned long start, unsigned long end,
unsigned long block_size, unsigned long cplb_data)
Expand Down Expand Up @@ -206,19 +207,12 @@ fill_cplbtab(struct cplb_tab *table,

start += block_size;
}
return 0;
}

static unsigned short __init
close_cplbtab(struct cplb_tab *table)
static void __init close_cplbtab(struct cplb_tab *table)
{

while (table->pos < table->size) {

while (table->pos < table->size)
table->tab[table->pos++] = 0;
table->tab[table->pos++] = 0; /* !CPLB_VALID */
}
return 0;
}

/* helper function */
Expand Down Expand Up @@ -426,7 +420,7 @@ void __init generate_cplb_tables_cpu(unsigned int cpu)
}
}

/* close tables */
/* close tables */

close_cplbtab(&cplb.init_i);
close_cplbtab(&cplb.init_d);
Expand All @@ -437,5 +431,5 @@ void __init generate_cplb_tables_cpu(unsigned int cpu)
cplb.switch_d.tab[cplb.switch_d.pos] = -1;

}
#endif

#endif

0 comments on commit 3831638

Please sign in to comment.