Skip to content

Commit

Permalink
Revert "fbcon: bgcolor fix"
Browse files Browse the repository at this point in the history
This reverts commit 2d04a4a, which made
it impossible to make the softcursor use the highlight colors.

Yes, the fourth bit should be "blinking", but since we cannot reasonably
blink in fbcon, highlighting it with a bright background is preferable.

Reported-by: Pavel Machek <pavel@suse.cz>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Antonino A. Daplas <adaplas@pol.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Linus Torvalds committed Aug 11, 2008
1 parent 4fbb715 commit 3838f59
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/console/fbcon.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ struct fbcon_ops {
#define attr_fgcol(fgshift,s) \
(((s) >> (fgshift)) & 0x0f)
#define attr_bgcol(bgshift,s) \
(((s) >> (bgshift)) & 0x07)
(((s) >> (bgshift)) & 0x0f)

/* Monochrome */
#define attr_bold(s) \
Expand Down

0 comments on commit 3838f59

Please sign in to comment.