Skip to content

Commit

Permalink
OMAP: DSS2: HDMI: improve hdmi output enable
Browse files Browse the repository at this point in the history
Enabling HDMI output often causes sync lost errors, and almost always
causes timeout errors being printed from dispc_mgr_enable_digit_out().

The sync lost problem seems to go lessen greatly if we first enable the
HDMI output, and only then enable the DISPC output. However, as this is
only based on observations, the fix may not be perfect as the problem
may lie somewhere else. Nevertheless, HDMI works better with this patch.

This will also fix the dispc's dispc_mgr_enable_digit_out(), as the code
waits for two VSYNCs after enabling the output. If the HDMI output is
disabled (as it was previously), there are no VSYNCs and
dispc_mgr_enable_digit_out() will print timeout errors.

Cc: Mythri P K <mythripk@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Tomi Valkeinen committed Sep 30, 2011
1 parent e82b090 commit 3870c90
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/video/omap2/dss/hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -529,10 +529,10 @@ static int hdmi_power_on(struct omap_dss_device *dssdev)
dispc_set_digit_size(dssdev->panel.timings.x_res,
dssdev->panel.timings.y_res);

dispc_mgr_enable(OMAP_DSS_CHANNEL_DIGIT, 1);

hdmi.ip_data.ops->video_enable(&hdmi.ip_data, 1);

dispc_mgr_enable(OMAP_DSS_CHANNEL_DIGIT, 1);

return 0;
err:
hdmi_runtime_put();
Expand Down

0 comments on commit 3870c90

Please sign in to comment.