Skip to content

Commit

Permalink
[media] exynos4-is: Fix potential null pointer dereferencing
Browse files Browse the repository at this point in the history
If fimc->drv_data is NULL, then fimc->drv_data->num_entities would
cause NULL pointer dereferencing. Hence remove it from print statement.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Sachin Kamat authored and Mauro Carvalho Chehab committed Apr 25, 2013
1 parent 5f3f254 commit 38c602b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/media/platform/exynos4-is/fimc-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -955,8 +955,8 @@ static int fimc_probe(struct platform_device *pdev)
}
if (!fimc->drv_data || fimc->id >= fimc->drv_data->num_entities ||
fimc->id < 0) {
dev_err(dev, "Invalid driver data or device id (%d/%d)\n",
fimc->id, fimc->drv_data->num_entities);
dev_err(dev, "Invalid driver data or device id (%d)\n",
fimc->id);
return -EINVAL;
}
if (!dev->of_node)
Expand Down

0 comments on commit 38c602b

Please sign in to comment.